-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tempo components docker workflow from Drone to GHA #4501
Conversation
8dc3f40
to
3f15571
Compare
this was needed to authenticate to GAR |
3f15571
to
1bf3a81
Compare
I've tested the steps except for docker push and the deployment-tools update: https://github.com/grafana/tempo/actions/runs/12596510374/job/35107743009?pr=4501 |
c812d43
to
360d183
Compare
This includes building the binaries, building and pushing the docker images to Dockerhub, and updating deployment-tools so tempo-dev-01 uses the latest images.
360d183
to
725f0f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sane and I don't think it's worth digging into all the details. It will either work or it won't :)
Let me know when you're ready to merge.
I do not have permission to merge as it's a branch in the upstream repo, so please merge at your convenience. We will then see if the docker push and the deployment-tools update work, if not we can revert it. |
@carles-grafana merging it. |
This includes building the binaries, building and pushing the docker images
to Dockerhub, and updating deployment-tools so tempo-dev-01 uses the latest images.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]