Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tempo components docker workflow from Drone to GHA #4501

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

carles-grafana
Copy link
Contributor

@carles-grafana carles-grafana commented Jan 2, 2025

This includes building the binaries, building and pushing the docker images
to Dockerhub, and updating deployment-tools so tempo-dev-01 uses the latest images.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@carles-grafana carles-grafana force-pushed the drone-migrate-docker branch 5 times, most recently from 8dc3f40 to 3f15571 Compare January 3, 2025 09:52
@carles-grafana
Copy link
Contributor Author

this was needed to authenticate to GAR
https://github.com/grafana/deployment_tools/pull/206623/files

@carles-grafana
Copy link
Contributor Author

I've tested the steps except for docker push and the deployment-tools update: https://github.com/grafana/tempo/actions/runs/12596510374/job/35107743009?pr=4501

@carles-grafana carles-grafana force-pushed the drone-migrate-docker branch 2 times, most recently from c812d43 to 360d183 Compare January 3, 2025 10:55
@carles-grafana carles-grafana marked this pull request as ready for review January 3, 2025 11:05
This includes building the binaries, building and pushing the docker images
to Dockerhub, and updating deployment-tools so tempo-dev-01 uses the latest images.
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane and I don't think it's worth digging into all the details. It will either work or it won't :)

Let me know when you're ready to merge.

@carles-grafana
Copy link
Contributor Author

This looks sane and I don't think it's worth digging into all the details. It will either work or it won't :)

Let me know when you're ready to merge.

I do not have permission to merge as it's a branch in the upstream repo, so please merge at your convenience.

We will then see if the docker push and the deployment-tools update work, if not we can revert it.

@electron0zero
Copy link
Member

I do not have permission to merge as it's a branch in the upstream repo, so please merge at your convenience.

@carles-grafana merging it.

@electron0zero electron0zero merged commit b08688e into main Jan 7, 2025
18 checks passed
@electron0zero electron0zero deleted the drone-migrate-docker branch January 7, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants