-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve config at HTTP endpoint #446
Conversation
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tempo can include sensitive information in its config. We either need to find a way to redact that or perhaps only serve this endpoint if it's configured.
Good point, I had not considered that. I was following suit with Cortex, which serves config by default I guess. |
Okay, cortex is clever :) - https://github.com/cortexproject/cortex/blob/master/pkg/util/flagext/secret.go I'll reuse this. |
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Results in
|
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay [email protected]
What this PR does:
Adds a
/config
handler to serve the config that tempo is running with. Makes it easier to debug in non-k8s environments.Long term, we should add an API module similar to Cortex.
Which issue(s) this PR fixes:
Fixes #nada
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]