Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This fixes a gap in autocomplete where it's possible to autocomplete an attribute that's already being filtered in the query. This should be a noop but is actually executed.
Example:
/api/v2/search/tag/name/values?query={name="foo"}
Since we already know
name
must befoo
, there is no reason to scan for the autocomplete values.This PR adds the check to ExecuteTagValues in the engine. This is lower than preferred, ideally we would add this to the query-frontend, but the amount of pipeline reuse, and the location of the loose parsing of
query
make that non-trivial. But want to get this fix in sooner.Notes:
It's only valid to exit early when it is the Equal operation, and not any case where the attribute is present in the query. For example these queries are filtering the same tag but can still return a range of values:
{ .foo =~ "bar.*"}
{ .foo > 0 }
{ .foo != nil }
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]