[DOC] Add overrides info to tempo-distributed doc #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
|
@zalegrala Would you review this PR? |
electron0zero
approved these changes
Dec 5, 2024
docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md
Outdated
Show resolved
Hide resolved
|
Thank you for the review! I've changed the note to an admonition, so it will be more apparently in the text. |
This was referenced Dec 5, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a section to the tempo-distributed Helm chart documentation explaining overrides and provide a sample configuration.
The overrides section in the tempo-distributed Helm chart wasn't documented well and the configuration used didn't quite match the explanation in the Tempo configuration doc. This PR adds an example to the tempo-distributed Helm chart guide. We'll have another PR that will address issues in the tempo-distributed README.
Which issue(s) this PR fixes:
Fixes #3820
Related:
metrics-generatoridle and no traces are generated using Tempo 2.5.0 #3855Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]