-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add deprecation for metrics summary #4193
[DOC] Add deprecation for metrics summary #4193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Jennifer Villa <[email protected]>
* Add deprecation for metrics summary * Update docs/sources/tempo/api_docs/metrics-summary.md * Update docs/sources/tempo/api_docs/metrics-summary.md * Apply suggestions from code review Co-authored-by: Jennifer Villa <[email protected]> --------- Co-authored-by: Jennifer Villa <[email protected]> (cherry picked from commit 760ce80)
* Add deprecation for metrics summary * Update docs/sources/tempo/api_docs/metrics-summary.md * Update docs/sources/tempo/api_docs/metrics-summary.md * Apply suggestions from code review Co-authored-by: Jennifer Villa <[email protected]> --------- Co-authored-by: Jennifer Villa <[email protected]>
sorry for hijacking, is there a problem with metrics summary feature? should I not use it, or is there a replacement |
There is no problem with it. Its simply that this API is now redundant given that we have TraceQL metrics queries, and we'd like to deprecate it in order to reduce our maintenance burden. TraceQL metrics queries are in fact significantly more powerful that what you get with the metrics summary API since they can look at arbitrary time windows (not just the last hour), return time series information (rather than just a single instant value over the past hour), and can look at all spans (not just kind=server). To provide an example, if you were to aggregate by
Rate of requests by resource.cloud.region
Error rate by resource.cloud.region
p99, p90, and p50 latency by resource.cloud.region Or if you want the even easier approach than typing out these queries by hand, we suggest using Explore Traces which is a queryless experience for navigating your trace data stored in Tempo powered by TraceQL metrics queries under the hood. |
Thanks for the reply. I am stuck on getting metric query to work for some time now. this is my yaml file for latest tempo-distributed helm chart. Any pointer much appreciated!
|
Unfortunately, that's something I don't know how to help debug, and I think this probably isn't the right place for that. My suggestion is you try some of our community forums for help. |
Thanks for the response! |
@MrMegaMango Thank you for asking the question! I've updated the docs here: #4316 |
What this PR does:
Adds a deprecation note for metrics summary API. Aggregate by is already marked as deprecated in Grafana Cloud.
Part of https://github.com/grafana/website/pull/22148 and https://github.com/grafana/tempo-squad/issues/438
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]