Generator remote write update handling of X-Scope-OrgID #4021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR changes the header precedence in Generator remote write, so that statically configured X-Scope-OrgID is honored. This change is necessary to unlock a use case that is currently not possible. Will do my best to explain. The desired behavior is to have a setup like this:
{__id__="<tenantid>"}
Target B doesn't work currently because the logic gives highest precedence to dynamically set X-Scope-OrgID. The statically configured header is deleted and a warning logged.
This logic was inherited and designed to protect against broken authentication, but after review it doesn't seem a compelling use case. Remote write headers can be set in two locations:
Both locations are statically configured by a Tempo operator, and it is more likely they are intentional than not.
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]