Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MinID/MaxID from BlockMeta #3950

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Aug 9, 2024

What this PR does:

To shrink the size of the BlockMeta, here we drop two fields that should have very little overall impact due to their light use.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala force-pushed the blockMetaMinMax branch 3 times, most recently from ac98dde to 3889306 Compare August 9, 2024 14:14
To shrink the size of the BlockMeta, here we drop two fields that should
have very little overall impact due to their light use.
@zalegrala zalegrala marked this pull request as ready for review August 9, 2024 15:05
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog? i feel like you have a few coming, maybe just one changelog entry for all?

@zalegrala
Copy link
Contributor Author

I'll add to that changelog entry on the other PRs.

@zalegrala zalegrala merged commit 5768277 into grafana:main Aug 9, 2024
16 checks passed
@zalegrala zalegrala deleted the blockMetaMinMax branch August 9, 2024 16:20
@joe-elliott joe-elliott mentioned this pull request Sep 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants