-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo tempo-cli with basic command structure and improvements #385
Conversation
…flag, print results more dynamically
Welcome improvement in both code organization and tempo-cli ux. The current main readme.md now contains some out of date info on tempo-cli. What do you think about adding updated info to the |
…ocs for tempo-cli
Agree. Added CLI section to docs that covers commands, options, etc, and updated readme to link to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, thank you @mdisibio! Can you please also add a CHANGELOG entry and then we can merge this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc content looks good. Added some copy-edit suggestions.
What this PR does:
Redo of tempo-cli to have basic command structure for easier maintenance and new commands. Existing three commands now look like:
tempo-cli list block <tenant-id> <block-id>
tempo-cli list blocks <tenant-id>
tempo-cli query <trace-id>
Notable changes:
Which issue(s) this PR fixes:
Fixes #281
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]