-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parquet] Performance improvement by checking column dictionary earlier #2676
Merged
mdisibio
merged 15 commits into
grafana:main
from
mdisibio:parquetquery-keepcolumnchunk
Jul 20, 2023
Merged
[Parquet] Performance improvement by checking column dictionary earlier #2676
mdisibio
merged 15 commits into
grafana:main
from
mdisibio:parquetquery-keepcolumnchunk
Jul 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed so it isn't wasted work
…aryHelper is not obsolete and removed
mapno
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checks column dictionaries as early as possible in KeepColumnChunk so that we can skip over them properly. Previously we had to wait for the first page because of the library design, and even though we short-circuited some of the logic, we still had to perform all of the I/o and decoding. This improvement mostly applies to needle-in-the-haystack or low cardinality values, where the skip occurs. Benchmarks below. In the situations where MB/s went down, it's because the I/O went down faster than cpu.
This new way of checking the dictionary also benefits SearchTagValues. I know this will conflict with the vParquet3 PR so we can revert it if we want, but there is still at least the 1-line change to the
Predicate.KeepColumnChunk
method signature.Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]