Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow configuring a prefix path for s3 #2362

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

kousikmitra
Copy link
Contributor

@kousikmitra kousikmitra commented Apr 24, 2023

What this PR does:

Enables storing blocks in shared s3 bucket with the prefix option.

image

Which issue(s) this PR fixes:
Fixes #2100

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it LGTM

@kousikmitra kousikmitra force-pushed the feat/s3-prefix-config branch from ad186df to b49e816 Compare April 25, 2023 17:02
@kousikmitra kousikmitra changed the title Feature: Allow configuring a prefix path for s3 Enhancement: Allow configuring a prefix path for s3 Apr 25, 2023
@mapno mapno enabled auto-merge (squash) April 26, 2023 08:00
@mapno mapno merged commit a55da81 into grafana:main Apr 26, 2023
@kousikmitra kousikmitra deleted the feat/s3-prefix-config branch April 27, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure subpaths within S3 buckets
3 participants