span id to hex #2062
Merged
span id to hex #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie-pham
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn and
zalegrala
as code owners
joe-elliott
reviewed
Feb 3, 2023
joe-elliott
reviewed
Feb 13, 2023
joe-elliott
reviewed
Feb 21, 2023
joe-elliott
reviewed
Feb 21, 2023
|
@joe-elliott One last question, extra logic would have to be added to this I believe but what happens if the span id has leading zeroes and it is longer than 16 characters? Still no trimming? |
since we're in "shouldn't happen" territory i'm fine with anything that:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2062-to-release-v2.0 origin/release-v2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 2d50f21918c81a433e62b6f9b759ca7b98ed7482
# Push it to GitHub
git push --set-upstream origin backport-2062-to-release-v2.0
git switch main
# Remove the local backport branch
git branch -D backport-2062-to-release-v2.0Then, create a pull request where the |
joe-elliott
pushed a commit
that referenced
this pull request
Feb 23, 2023
* span id to hex * logic * simplify * fmt * update test * what is logic * changelog (cherry picked from commit 2d50f21)
Merged
joe-elliott
added a commit
that referenced
this pull request
Feb 23, 2023
* span id to hex * logic * simplify * fmt * update test * what is logic * changelog (cherry picked from commit 2d50f21) Co-authored-by: Jennie Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: stop removing leading zeroes in span ids
Which issue(s) this PR fixes:
Fixes #2060
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]