Procect forwarder watchOverrides from race condition #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
dgzlopes,
yvrhdn and
zalegrala
as code owners
mapno
force-pushed
the
forwarder-race-condition
branch
from
3488285 to
9574f31
Compare
joe-elliott
approved these changes
Jun 2, 2022
mapno
force-pushed
the
forwarder-race-condition
branch
from
e28355b to
c588e2c
Compare
Reworks update logic in watchOverrides loop. The race condition comes from the unpredictable behaviour of ranging over a map. This could cause that a newly created queueManagers was added to the ranged map, and be evaluated for update. Since the queueManager was _just_ created, it wouldn't have enough running workers, which would trigger another update.
mapno
force-pushed
the
forwarder-race-condition
branch
from
c0234b8 to
2ed7d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Reworks update logic in watchOverrides loop.
The race condition comes from the unpredictable behaviour of ranging over a map.
This could cause that a newly created queueManagers was added to the ranged map,
and be evaluated for update.
Since the queueManager was just created, it wouldn't have enough running workers,
which would trigger another update.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]