-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Query-frontend doesn't log request details when request is cancelled #1241
Conversation
I added 5sec sleep in
|
Thanks for the contribution! I have wanted something like this in the past. Had one question regarding the status returned. |
I think this PR is ready to go. It just needs a small change for the linter:
|
apologies, I missed lint. I'll take care from now on. |
no worries! I forget to lint before pushing all the time 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! thanks for the contribution!
What this PR does:
I've added a logline before returning. When the request is canceled a usual logline(info) is printed but with status 499
Which issue(s) this PR fixes:
Fixes #1136
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]