-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for inline environments #1184
Conversation
6a2486e
to
e3ce7d2
Compare
7f6d429
to
0d14159
Compare
This is a fairly enormous update of dependencies in our jsonnet library that will be very difficult to review. Is it possible to make your addition without updating the dependencies? Also a readme or other guide might be nice to help people understand why this pattern exists and what it is useful for. |
Hi @joe-elliott
which is needed to create tanka environments in jsonnet. About the docs, let me know the way you'd prefer me to document this. |
Hi @joe-elliott If I only add
After updating the dependencies instead I get the manifests right. Also I refactored the commit to split it into 2 separated ones: one for the dependency updates and one for the actual changes. Hope this way you better understand what the changes are |
Ah, ok, I'm understanding more about what this change is. Thank you for the details. The only thing I'd ask is that you add some details in the readme here: https://github.com/grafana/tempo/tree/main/example/tk Explain why this is a powerful pattern and someone may want to use it while deploying Tempo. Thanks for sticking with this! |
@joe-elliott I've added some docs in the readme you specified, please let me know |
Signed-off-by: irizzant <[email protected]>
Signed-off-by: irizzant <[email protected]>
Signed-off-by: irizzant <[email protected]>
Signed-off-by: irizzant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @irizzant!
I'm not super familiar with the inline jsonnet pattern. Thanks for getting an example in our repo.
You're most welcome @joe-elliott , thank you By the way, I'm not super familiar with it either, I learned about it when I started deploying Tempo with the provided examples and I found it powerful and useful enough to be shared 🤣 |
What this PR does:
Adds support for inline environments (https://tanka.dev/inline-environments).
This way users can import the example they want to use (single binary, microservices) in their clusters.libsonnet file and customize any aspect of the environment they want to deploy.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]