Search: parse tags from a tags query parameter #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvrhdn
force-pushed
the
search-api-isolate-tags
branch
from
7e1599e to
2f579ef
Compare
|
You can send a test request using curl: This will send the following request: |
added 11 commits
October 19, 2021 18:21
# Conflicts: # modules/querier/querier_search.go
yvrhdn
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
mdisibio
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
LGTM. Agree with using logfmt (to start at least). Addresses all of my concerns in #1038 (comment)
This was referenced Oct 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Experiment to try out parsing search request tags from a
tagsquery parameter.Instead of specifying every tag as it's own query parameter, we put them all in the
tagsquery parameter, separated by a space (logfmt style).To remain compatible with the current Grafana search implementation we still parse top-level tag query parameters. As Grafana updates this can be removed.
The actual parsing of tags is handled by go-logfmt.
In a next PR I plan to move this code into
pkg/apiand reuse code withParseBackendSearch(if it makes sense)Which issue(s) this PR fixes:
Experiment related to #1038
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]