Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jsonnet-libs 1.19 and update tk examples #1001

Merged
merged 3 commits into from
Oct 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
* [ENHANCEMENT] Support global denylist and per-tenant allowlist of tags for search data. [#960](https://github.com/grafana/tempo/pull/960) (@annanay25)
* [ENHANCEMENT] Add `search_query_timeout` to Querier config. [#984](https://github.com/grafana/tempo/pull/984) (@kvrhdn)
* [ENHANCEMENT] Jsonnet: add `$._config.memcached.memory_limit_mb` [#987](https://github.com/grafana/tempo/pull/987) (@kvrhdn)
* [ENHANCEMENT] Upgrade jsonnet-libs to 1.19 and update tk examples [#1001](https://github.com/grafana/tempo/pull/1001) (@mapno)
* [BUGFIX] Update port spec for GCS docker-compose example [#869](https://github.com/grafana/tempo/pull/869) (@zalegrala)
* [BUGFIX] Fix "magic number" errors and other block mishandling when an ingester forcefully shuts down [#937](https://github.com/grafana/tempo/issues/937) (@mdisibio)
* [BUGFIX] Fix compactor memory leak [#806](https://github.com/grafana/tempo/pull/806) (@mdisibio)
Expand Down
6 changes: 3 additions & 3 deletions example/tk/jsonnetfile.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
{
"source": {
"git": {
"remote": "https://github.com/ksonnet/ksonnet-lib.git",
"subdir": "ksonnet.beta.4"
"remote": "https://github.com/jsonnet-libs/k8s-libsonnet.git",
"subdir": "1.19"
}
},
"version": "master"
"version": "main"
}
],
"legacyImports": true
Expand Down
16 changes: 8 additions & 8 deletions example/tk/jsonnetfile.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"subdir": "ksonnet-util"
}
},
"version": "eae352a28812274df34ccee8a7edec3a97a1ef95",
"sum": "sI6Hgng7yR8fkgHqJ10e3rQagVhpHhumAKqqzbOZUSM="
"version": "37319e21e546579eab2c3ed459e956a262c28f8c",
"sum": "OxgtIWL4hjvG0xkMwUzZ7Yjs52zUhLhaVQpwHCbqf8A="
},
{
"source": {
Expand All @@ -18,18 +18,18 @@
"subdir": "memcached"
}
},
"version": "2829b0f8e18ec87c3a451fa01fcd11b6508b25b2",
"sum": "AIspZ151p0qkxVc9tuoAEYNrkazV6QncWWsIsarK9GE="
"version": "37319e21e546579eab2c3ed459e956a262c28f8c",
"sum": "dTOeEux3t9bYSqP2L/uCuLo/wUDpCKH4w+4OD9fePUk="
},
{
"source": {
"git": {
"remote": "https://github.com/ksonnet/ksonnet-lib.git",
"subdir": "ksonnet.beta.4"
"remote": "https://github.com/jsonnet-libs/k8s-libsonnet.git",
"subdir": "1.19"
}
},
"version": "0d2f82676817bbf9e4acf6495b2090205f323b9f",
"sum": "ur22hPQq0JAPBxm8hNMcwjumj4MkozDwOKiGZvVMYh4="
"version": "f47562c4e3bfaf46a5a5bc6a9e1e76a4fc76c18e",
"sum": "m/53207lTQJGAA9H2D7SrM+qIMJxHxXPzlsx3GuyYLg="
}
],
"legacyImports": false
Expand Down
6 changes: 5 additions & 1 deletion example/tk/lib/grafana/main.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
grafana_service:
k.util.serviceFor($.grafana_deployment)
+ service.mixin.spec.withPortsMixin([
servicePort.withName('http').withPort(3000).withTargetPort(3000),
servicePort.newNamed(
name='http',
port=3000,
targetPort=3000,
),
]),
}
2 changes: 1 addition & 1 deletion example/tk/lib/k.libsonnet
Original file line number Diff line number Diff line change
@@ -1 +1 @@
import "ksonnet.beta.4/k.libsonnet"
import 'github.com/jsonnet-libs/k8s-libsonnet/1.19/main.libsonnet'
2 changes: 1 addition & 1 deletion example/tk/lib/minio/minio.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
container.withCommand([
'sh',
'-euc',
'mkdir -p /data/tempo && /usr/bin/minio server /data',
'mkdir -p /data/tempo && minio server /data',
]) +
container.withEnvMap({
MINIO_ACCESS_KEY: 'tempo',
Expand Down
20 changes: 11 additions & 9 deletions example/tk/tempo-microservices/main.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -104,19 +104,21 @@ minio + grafana + load + tempo {
}
},

local ingress = k.networking.v1beta1.ingress,
local ingress = k.networking.v1.ingress,
local rule = k.networking.v1.ingressRule,
local path = k.networking.v1.httpIngressPath,
ingress:
ingress.new() +
ingress.new('ingress') +
ingress.mixin.metadata
.withName('ingress')
.withAnnotations({
.withAnnotationsMixin({
'ingress.kubernetes.io/ssl-redirect': 'false'
}) +
ingress.mixin.spec.withRules(
ingress.mixin.specType.rulesType.mixin.http.withPaths(
ingress.mixin.spec.rulesType.mixin.httpType.pathsType.withPath('/') +
ingress.mixin.specType.mixin.backend.withServiceName('grafana') +
ingress.mixin.specType.mixin.backend.withServicePort(3000)
),
rule.http.withPaths([
path.withPath('/')
+ path.withPathType('ImplementationSpecific')
+ path.backend.service.withName('grafana')
+ path.backend.service.port.withNumber(3000)
]),
),
}
20 changes: 11 additions & 9 deletions example/tk/tempo-single-binary/main.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,21 @@ grafana + load + tempo {
containerPort.new('jaeger-http', 14268),
]),

local ingress = k.networking.v1beta1.ingress,
local ingress = k.networking.v1.ingress,
local rule = k.networking.v1.ingressRule,
local path = k.networking.v1.httpIngressPath,
ingress:
ingress.new() +
ingress.new('ingress') +
ingress.mixin.metadata
.withName('ingress')
.withAnnotations({
.withAnnotationsMixin({
'ingress.kubernetes.io/ssl-redirect': 'false'
}) +
ingress.mixin.spec.withRules(
ingress.mixin.specType.rulesType.mixin.http.withPaths(
ingress.mixin.spec.rulesType.mixin.httpType.pathsType.withPath('/') +
ingress.mixin.specType.mixin.backend.withServiceName('grafana') +
ingress.mixin.specType.mixin.backend.withServicePort(3000)
),
rule.http.withPaths([
path.withPath('/')
+ path.withPathType('ImplementationSpecific')
+ path.backend.service.withName('grafana')
+ path.backend.service.port.withNumber(3000)
]),
),
}
1 change: 1 addition & 0 deletions example/tk/vendor/1.19

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading