Skip to content

Commit

Permalink
[Rhythm] Block-builder consumption loop (#4480)
Browse files Browse the repository at this point in the history
* Alternate block-builder consume

* Set timeout on PollFetches, reduce initial poll delay, update 1 test to work using real consumergroup functionality

* restore metrics

* Re-add original partition lag metric, polled in separate goroutine. Fix consume loop to only consume full-duration cycles for more determinism

* merge conflict

* Review feedback

* Review feedback

* Comment

* code cleanup, lint

* logs

* code cleanup

* lint

* Review feedback

* Remove missed lookback_on_no_commit config in e2e tests and regen manifest

* Review feedback
  • Loading branch information
mdisibio authored Jan 8, 2025
1 parent b8022f0 commit 6296572
Show file tree
Hide file tree
Showing 7 changed files with 160 additions and 444 deletions.
1 change: 0 additions & 1 deletion docs/sources/tempo/configuration/manifest.md
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,6 @@ block_builder:
instance_id: hostname
assigned_partitions: {}
consume_cycle_duration: 5m0s
lookback_on_no_commit: 12h0m0s
block:
max_block_bytes: 20971520
bloom_filter_false_positive: 0.01
Expand Down
1 change: 0 additions & 1 deletion integration/e2e/ingest/config-kafka.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ overrides:
path: /var/tempo/overrides

block_builder:
lookback_on_no_commit: 15m
consume_cycle_duration: 1m

ingest:
Expand Down
Loading

0 comments on commit 6296572

Please sign in to comment.