fix: handle fractional "check result" logs #1074
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When grafana/xk6-sm#34 is merged, it will be possible for
check result
logs to have fractional values, if the same check name is used twice. For example, the following snippet:Currently yields:
After grafana/xk6-sm#34 is merged, it will yield
In terms of reporting, and given this will only happen if two
check
s with the same name are defined, I think it is okay to simplify and assume that if not 100% of thecheck
s with the same name are okay, the check has failed. So this PR changes the query to look for!= 1
instead of= 0
. Other queries already look for= 1
, so those shouldn't need changing.