ci: Fix argo workflow name conflict #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new release process, a push to main happens pretty much at the same time as the tag generation. Notice that the same naming is used for both workflows. This naming has a suffix that is set executing the ./scripts/version script, which will retrieve the current version with the command: git describe --dirty --tags --long --always If this command executed for the push CI is run after the tag is created, it will generate a workflow name that conflicts with the one to be created for the tag, not allowing the tag CI/CD to create its workflow. The fix adds an extra suffix to the workflow name that identifies the workflow "mode", dev for pushes to main, release for tags.
nadiamoe
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new release process, a push to main happens pretty much at the same time as the tag generation. Notice that the same naming is used for both workflows. This naming has a suffix that is set executing the ./scripts/version script, which will retrieve the current version with the command:
git describe --dirty --tags --long --always
If this command executed for the push CI is run after the tag is created, it will generate a workflow name that conflicts with the one to be created for the tag, not allowing the tag CI/CD to create its workflow.
The fix adds an extra suffix to the workflow name that identifies the workflow "mode", dev for pushes to main, release for tags.