Fix telemetry error handling #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to defer error handling through an anonymous function so the closure captures the err var reference and it can be evaluated correctly at the end of the function execution.
nadiamoe
approved these changes
Mar 7, 2024
| @@ -173,7 +174,7 @@ func (p *RegionPusher) push(m sm.RegionTelemetry) { | |||
| ) | |||
|
|
|||
| start := p.metrics.start() | |||
| defer p.metrics.end(err, start) | |||
| defer func() { p.metrics.end(err, start) }() | |||
There was a problem hiding this comment.
Ah, the classic. Been there done that 😅
ka3de
added a commit
that referenced
this pull request
Mar 11, 2024
* Send adhoc check done logs to Loki without --verbose (#631) * Chore(deps): Bump github.com/prometheus/prometheus from 0.50.0 to 0.50.1 * Configure blacklist ip range for k6 runner (#633) * Add telemetry (#621) * Fix: telemetry region label (#638) * Chore(deps): Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#640) * Chore(deps): Bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#628) * Chore(deps): Bump golang.org/x/net from 0.21.0 to 0.22.0 (#642) * Chore(deps): Bump github.com/prometheus/common from 0.47.0 to 0.49.0 * use expfmt.NewFormat instead of now-private formats directly * Feature: allow checks to run less often (#611) * Upgrade to grafana-build-tools v0.6.1 (#646) * Fix telemetry error handling (#650) * Use github.com/grafana/loki/pkg/pusher instead of logproto (#648) * Pass a scraper factory from main (#649) * Chore(deps): Bump google.golang.org/grpc from 1.62.0 to 1.62.1 * Chore(deps): Bump github.com/prometheus/common from 0.49.0 to 0.50.0 * Add telemetry sampled executions (#653) Signed-off-by: ka3de <[email protected]>
Merged
ka3de
added a commit
that referenced
this pull request
Mar 11, 2024
* Send adhoc check done logs to Loki without --verbose (#631) * Chore(deps): Bump github.com/prometheus/prometheus from 0.50.0 to 0.50.1 * Configure blacklist ip range for k6 runner (#633) * Add telemetry (#621) * Fix: telemetry region label (#638) * Chore(deps): Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#640) * Chore(deps): Bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#628) * Chore(deps): Bump golang.org/x/net from 0.21.0 to 0.22.0 (#642) * Chore(deps): Bump github.com/prometheus/common from 0.47.0 to 0.49.0 * use expfmt.NewFormat instead of now-private formats directly * Feature: allow checks to run less often (#611) * Upgrade to grafana-build-tools v0.6.1 (#646) * Fix telemetry error handling (#650) * Use github.com/grafana/loki/pkg/pusher instead of logproto (#648) * Pass a scraper factory from main (#649) * Chore(deps): Bump google.golang.org/grpc from 1.62.0 to 1.62.1 * Chore(deps): Bump github.com/prometheus/common from 0.49.0 to 0.50.0 * Add telemetry sampled executions (#653) Signed-off-by: ka3de <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.