Fix: allow getting API token from environment #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
approved these changes
Nov 25, 2022
Allow the API token to be obtained from the environment variable SM_AGENT_API_TOKEN. If it's passed on the command line, that value takes precedence. For backwards compatibility, in case the user decides to NOT replace the existing configuration files (in Debian these are config files, and the user has the option to NOT replace them during an upgrade if they have edited them, and because of the way we have set this up, they *have* edited them). In the shipped systemd service file, replace passing the token on the command line in favor of passing it on the environment. Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
get_api_token_from_env
branch
from
9f2dae6 to
b784500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the API token to be obtained from the environment. If it's passed on the command line, that value takes precedence.
Use this mechanism in the shipped systemd service file.
Signed-off-by: Marcelo E. Magallon [email protected]