feat: Rename push-to-dockerhub-action (#33)

grafana · Jan 16, 2024 · 6730582 · 6730582
1 parent 494f180
commit 6730582
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/actions/push-to-dockerhub/README.md → actions/build-push-to-dockerhub/README.md b/actions/push-to-dockerhub/README.md → actions/build-push-to-dockerhub/README.md
@@ -1,6 +1,6 @@
-# push-to-dockerhub
+# build-push-to-dockerhub
 
-This is a composite GitHub Action, used to push docker images to DockerHub.
+This is a composite GitHub Action, used to build Docker images and push them to DockerHub.
 It uses `get-vault-secrets` action to get the DockerHub username and password from Vault.
 
 Example of how to use this action in a repository:
@@ -20,7 +20,7 @@ jobs:
 
     steps:
       - id: push-to-dockerhub
-        uses: grafana/shared-workflows/actions/push-to-dockerhub@main
+        uses: grafana/shared-workflows/actions/build-push-to-dockerhub@main
         with:
           repository: ${{ github.repository }} # or any other dockerhub repository
           context: .

diff --git a/actions/push-to-dockerhub/action.yaml → actions/build-push-to-dockerhub/action.yaml b/actions/push-to-dockerhub/action.yaml → actions/build-push-to-dockerhub/action.yaml
@@ -13,6 +13,10 @@ inputs:
     description: |
       Path to Dockerfile, which is used to build the image.
     default: "."
+  push:
+    description: |
+      Push the generated images also to DockerHub
+    default: "false"
 
 runs:
   using: composite
@@ -45,6 +49,6 @@ runs:
       uses: docker/build-push-action@3b5e8027fcad23fda98b2e3ac259d8d67585f671
       with:
         context: ${{ inputs.context }}
-        push: ${{ github.event_name == 'push' }}
+        push: ${{ inputs.push }}
         tags: ${{ steps.meta.outputs.tags }}
         labels: ${{ steps.meta.outputs.labels }}