Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to dskit without log.Interface and logrus #2270

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Upgrade to dskit without log.Interface and logrus #2270

merged 1 commit into from
Aug 18, 2023

Conversation

duricanikolic
Copy link
Contributor

This PR upgrades dskit and uses dskit's log package for the creation of the global logger.
For the main in the dskit see grafana/dskit#359.

@duricanikolic duricanikolic requested a review from a team as a code owner August 17, 2023 17:33
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

simonswine
simonswine approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

Works as far as I can tell

@simonswine simonswine merged commit 8e158f4 into grafana:next Aug 18, 2023
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duricanikolic @CLAassistant @simonswine