Feat: Add flag to select specific analyzer to run #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshirohugo
requested review from
sunker,
wbrowne,
marefr and
andresmgot
and removed request for
a team
academo
reviewed
Oct 30, 2024
There was a problem hiding this comment.
nice! please make sure to add an integration test with this case here
https://github.com/grafana/plugin-validator/blob/main/pkg/cmd/plugincheck2/main_test.go
You can use the same fixtures
Also remember to update the README file to include this flag in the documentation
academo
approved these changes
Nov 5, 2024
xnyo
approved these changes
Nov 5, 2024
pkg/cmd/plugincheck2/main_test.go
Outdated
Comment on lines
31
to
35
| type TC struct { | ||
| File string | ||
| ExtraArgs string | ||
| JsonReport JsonReport | ||
| } |
There was a problem hiding this comment.
Nit: can we unexport this?
Suggested change
| type TC struct { | |
| File string | |
| ExtraArgs string | |
| JsonReport JsonReport | |
| } | |
| type tc struct { | |
| file string | |
| extraArgs string | |
| jsonReport JsonReport | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to
plugincheck2command line:analyzer. It will allow us to select individuals analyzers to run.This will allow us to use
plugincheck2in the CI provided bycreate-pluginto validade theplugin.jsonformat as required here: grafana/plugin-tools#1062OBS: The way that our analyzers are implemented will guarantee that all the required analyzer will run even when individual analyzers are selected to run with the new flag.