Console log: Exclude test files #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
requested review from
academo,
wbrowne,
andresmgot and
oshirohugo
and removed request for
a team
academo
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed and why?
We tend to see some false-positives when validating plugins for using
console.log(), mostly when these are used in files that are not part of the actual production code, but are in tests or any other dev-env related code. E.g.:This PR excludes test files from the validation.
To the reviewer
There is a chance that this is suppressing errors in case a test file is imported to production code. Although the false positives are not ideal, maybe it's better to have those than to miss on a potential console.log() in an imported test file. (I don't think this would really happen to be honest, and even if it does it's not crucial.)