Trackingscripts: Check for urls #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
requested review from
jackw,
wbrowne,
andresmgot and
xnyo
and removed request for
a team
leventebalogh
approved these changes
Jul 22, 2024
| t, | ||
| interceptor.Diagnostics[0].Detail, | ||
| "Tracking scripts are not allowed in Grafana plugins (e.g. google analytics). Please remove any usage of tracking code. Found: https://www.google-analytics.com/analytics.js", | ||
| ) |
There was a problem hiding this comment.
Would be nice to add a test case that checks for this improvement (e.g. that grafana-asserts-app.rules:read doesn't trigger "pp.ru").
jackw
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the logic for the tracking scripts to check only inside urls and not all the code to prevent false positives.