Hackaton: Experimental OpenAI-GPT code validation with tzap #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnyo
reviewed
Aug 9, 2023
| } | ||
|
|
||
| var Analyzer = &analysis.Analyzer{ | ||
| Name: "go-sec", |
There was a problem hiding this comment.
Typo?
Suggested change
| Name: "go-sec", | |
| Name: "tzap", |
Comment on lines
90
to
91
| err = nil | ||
| retry-- |
There was a problem hiding this comment.
I'm a bit confused by this. Won't this cause err to always be nil, and why is retry decreased if i is already increasing?
There was a problem hiding this comment.
Thanks. I think I am mistaken in how the err object is assigned and the retry-- is a leftover from a previous logic. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for experimental validations using openai-gpt. It uses tzap (MIT License) to run validations against the plugin source code.
GPT models are not fully reliable in code analysis and thus a new "suspected" report category is introduced in this PR to prevent false positives to leak into a more deterministic analysis from the other analysis