Tracking scripts: Add missing test case (#237)

* Trackingscripts: Check for urls * Do not stop after finding the first * Add missing test case * Add tracking test
grafana · Jul 22, 2024 · 3bfde5a · 3bfde5a
1 parent f03c5c1
commit 3bfde5a
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/pkg/analysis/passes/trackingscripts/trackingscripts_test.go b/pkg/analysis/passes/trackingscripts/trackingscripts_test.go
@@ -55,3 +55,21 @@ func TestTrackingScriptsInvalid(t *testing.T) {
 		"Tracking scripts are not allowed in Grafana plugins (e.g. google analytics). Please remove any usage of tracking code. Found: https://www.google-analytics.com/analytics.js",
 	)
 }
+
+func TestNoFalsePositiveForSringsLookingLikeDomains(t *testing.T) {
+	var interceptor testpassinterceptor.TestPassInterceptor
+	var moduleJsMap = map[string][]byte{
+		"module.js": []byte(`grafana-asserts-app.rules:read`),
+	}
+	pass := &analysis.Pass{
+		RootDir: filepath.Join("./"),
+		ResultOf: map[*analysis.Analyzer]interface{}{
+			modulejs.Analyzer: moduleJsMap,
+		},
+		Report: interceptor.ReportInterceptor(),
+	}
+
+	_, err := Analyzer.Run(pass)
+	require.NoError(t, err)
+	require.Len(t, interceptor.Diagnostics, 0)
+}