Feat: Change metadatavalid default severity (#271)

grafana · Nov 7, 2024 · 32dae9d · 32dae9d
1 parent 882de9a
commit 32dae9d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/analysis/passes/metadatavalid/metadatavalid.go b/pkg/analysis/passes/metadatavalid/metadatavalid.go
@@ -15,7 +15,7 @@ import (
 )
 
 var (
-	invalidMetadata  = &analysis.Rule{Name: "invalid-metadata", Severity: analysis.Warning}
+	invalidMetadata  = &analysis.Rule{Name: "invalid-metadata", Severity: analysis.Error}
 	metadataNotFound = &analysis.Rule{Name: "metadata-not-found", Severity: analysis.Error}
 )
 

diff --git a/pkg/cmd/plugincheck2/main_test.go b/pkg/cmd/plugincheck2/main_test.go
@@ -188,7 +188,7 @@ func TestIntegration(t *testing.T) {
 					},
 					"metadatavalid": {
 						{
-							Severity: "warning",
+							Severity: "error",
 							Title:    "plugin.json: dependencies: grafanaDependency is required",
 							Detail:   "The plugin.json file is not following the schema. Please refer to the documentation for more information. https://grafana.com/docs/grafana/latest/developers/plugins/metadata/",
 							Name:     "invalid-metadata",
@@ -222,7 +222,7 @@ func TestIntegration(t *testing.T) {
 				PluginValidator: map[string][]Issue{
 					"metadatavalid": {
 						{
-							Severity: "warning",
+							Severity: "error",
 							Title:    "plugin.json: dependencies: grafanaDependency is required",
 							Detail:   "The plugin.json file is not following the schema. Please refer to the documentation for more information. https://grafana.com/docs/grafana/latest/developers/plugins/metadata/",
 							Name:     "invalid-metadata",
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ import ( @@
     )
     var (
-    	invalidMetadata  = &analysis.Rule{Name: "invalid-metadata", Severity: analysis.Warning}
+    	invalidMetadata  = &analysis.Rule{Name: "invalid-metadata", Severity: analysis.Error}
     	metadataNotFound = &analysis.Rule{Name: "metadata-not-found", Severity: analysis.Error}
     )
@@ Expand Down @@