Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move sql-editor component from grafana/experimental #104

Merged
merged 3 commits into from
Oct 24, 2024
Merged

move sql-editor component from grafana/experimental #104

merged 3 commits into from
Oct 24, 2024

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Oct 23, 2024 •
edited
Loading

  1. move sql-editor component from grafana/experimental to grafana/plugin-ui.
  2. renames the component dir from sql-editor to SQLEditor to follow our naming convention.

TODO

  • test this component by replacing an experimental imported component to the new plugin-ui ver

@gwdawson gwdawson self-assigned this Oct 23, 2024
@idastambuk idastambuk mentioned this pull request Oct 23, 2024
Merged
@gwdawson
Copy link
Member Author

tested in yugabyte datasource by replacing replacing the grafana/experimental import with the grafana/plugin-ui import.

@gwdawson gwdawson merged commit 6837694 into main Oct 24, 2024
2 checks passed
@gwdawson gwdawson deleted the gareth/sql-editor-migration branch October 24, 2024 13:11
@idastambuk idastambuk mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idastambuk idastambuk idastambuk approved these changes

@cletter7 cletter7 Awaiting requested review from cletter7

@ivanahuckova ivanahuckova Awaiting requested review from ivanahuckova

Assignees

@gwdawson gwdawson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwdawson @idastambuk