Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin E2E: Fix datasource picker root locator #1483

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Plugin E2E: Fix datasource picker root locator #1483

merged 3 commits into from
Jan 27, 2025

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Jan 27, 2025 •
edited
Loading

What this PR does / why we need it:

This PR correctly sets the root locator for the datasource picker component. With this fix, we can properly solve this issue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]

@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker marked this pull request as ready for review January 27, 2025 09:28
@sunker sunker requested a review from a team as a code owner January 27, 2025 09:28
@sunker sunker requested a review from oshirohugo January 27, 2025 09:28
mckn
mckn approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunker sunker merged commit 07064f1 into main Jan 27, 2025
24 checks passed
@sunker sunker deleted the plugin-e2e/datasource-locator-fix branch January 27, 2025 09:59
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/[email protected], @grafana/[email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn approved these changes

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Status: 🚀 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunker @mckn