Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs display when _source is log message field #565

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Feb 4, 2025

What this PR does / why we need it:
Supports the _source field as the log message. Based on https://github.com/grafana/grafana/pull/80804/files

Which issue(s) this PR fixes:

Fixes #564

Special notes for your reviewer:

@iwysiu iwysiu marked this pull request as ready for review February 4, 2025 20:36
@iwysiu iwysiu requested a review from a team as a code owner February 4, 2025 20:36
@iwysiu iwysiu requested review from idastambuk and njvrzm and removed request for a team February 4, 2025 20:36
@idastambuk
Copy link
Contributor

idastambuk commented Feb 5, 2025

If I set _source in the Log message field, am I supposed to be seeing the raw _source message when log line is collapsed, or did I misunderstand what this is supposed to show?
Screenshot 2025-02-05 at 12 05 57

@iwysiu
Copy link
Contributor Author

iwysiu commented Feb 5, 2025

If I set _source in the Log message field, am I supposed to be seeing the raw _source message when log line is collapsed, or did I misunderstand what this is supposed to show? Screenshot 2025-02-05 at 12 05 57

Updated to actually use _source as a default log message value

@idastambuk
Copy link
Contributor

If I set _source in the Log message field, am I supposed to be seeing the raw _source message when log line is collapsed, or did I misunderstand what this is supposed to show? Screenshot 2025-02-05 at 12 05 57

Updated to actually use _source as a default log message value

Nice!
Screenshot 2025-02-05 at 17 30 40

@iwysiu iwysiu merged commit 28f2a50 into main Feb 5, 2025
13 checks passed
@iwysiu iwysiu deleted the iwysiu/564 branch February 5, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log messages are not handled properly when set to _source
2 participants