-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service to service model migration #5485
base: dev
Are you sure you want to change the base?
Conversation
Merge: Release oncall Helm chart 1.15.0
Will crate service-model Components for all technical and business services.
|
fix tests
forgot to add file
linting wise, check-out |
Some docs changes
fix linter
ran pip-compile
@joeyorlando Fixed your comments, tests, and linting. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall the business logic + structure of things LGTM 👍 just a few small remaining comments
use pytest, not unittest take out mysterious KUBECONFIG usage guard service migation on the overall config
What this PR does
Adds Service and Business Service migration to the Pager Duty Migrator.
To test, in addition to the OnCall configs, you need to crate a Grafana Service Account with
Admin
permission and generate a token. You will setGRAFANA_SERVICE_ACCOUNT_URL
, per the README, tohttps://<namespace>:<token>@<server>
The namespace is the stack id, in the format ofstacks-<stack id>
Service migration is configurable, filterable, and idempotent.
Which issue(s) this PR closes
Related to [issue link here]
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.