Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service to service model migration #5485

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

bcotton
Copy link
Contributor

@bcotton bcotton commented Mar 6, 2025

What this PR does

Adds Service and Business Service migration to the Pager Duty Migrator.

To test, in addition to the OnCall configs, you need to crate a Grafana Service Account with Admin permission and generate a token. You will set GRAFANA_SERVICE_ACCOUNT_URL, per the README, to https://<namespace>:<token>@<server> The namespace is the stack id, in the format of stacks-<stack id>

Service migration is configurable, filterable, and idempotent.

Which issue(s) this PR closes

Related to [issue link here]

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

joeyorlando and others added 4 commits February 18, 2025 13:26
Merge: Release oncall Helm chart 1.15.0
Will crate service-model Components for all technical
and business services.
@bcotton bcotton requested a review from a team as a code owner March 6, 2025 14:36
@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ bcotton
✅ joeyorlando
❌ actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.

fix tests
forgot to add file
@joeyorlando joeyorlando added the release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes label Mar 6, 2025
@joeyorlando
Copy link
Contributor

linting wise, check-out pre-commit in the root dir's Makefile (some commands for installing/running that which should get you squared away on those failing CI lint checks)

Some docs changes
ran pip-compile
@bcotton
Copy link
Contributor Author

bcotton commented Mar 7, 2025

@joeyorlando Fixed your comments, tests, and linting. PTAL

Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the business logic + structure of things LGTM 👍 just a few small remaining comments

use pytest, not unittest
take out mysterious KUBECONFIG usage
guard service migation on the overall config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants