feat: enhance PagerDuty migrator filtering + and improve user migration operations #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed filter logic to use OR operations between filter types - Added verbose logging option to reduce output spam - Fixed user handling when MIGRATE_USERS=false - Added migration progress summary - Updated tests and documentation
…n PAGERDUTY_FILTER_USERS is set and MIGRATE_USERS=true, now only the specified users will be migrated. Added filter_users function, updated migrate function, added tests, and updated documentation.
joeyorlando
force-pushed
the
joey/fix-pagerduty-migrator
branch
from
563bd15 to
b906140
Compare
joeyorlando
changed the title
joeyorlando
added
the
release:patch
| print( | ||
| f"Integrations: {sum(1 for i in integrations if i.get('oncall_type') and not i.get('is_escalation_policy_flawed'))} eligible of {filtered_resources_summary['integrations']} filtered" | ||
| ) | ||
| print("") |
There was a problem hiding this comment.
nit - is this for a new line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Improved Filtering Logic
New
PAGERDUTY_FILTER_USERSoption foradd_users_to_grafana.pyscriptadd_users_to_grafana.pyAdded Verbose Logging Option
PAGERDUTY_VERBOSE_LOGGINGenvironment variable to control output verbosityFixed User Handling
MIGRATE_USERS=falseMIGRATE_USERS=trueandPAGERDUTY_FILTER_USERSis set, only those specific users are migratedAdded Migration Progress Summary
Updated Tests
Updated Documentation
These changes address issues with filtering behavior and user handling, making the PagerDuty migrator more intuitive, efficient, and flexible.