fix synk security scan on CI #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Aug 20, 2024
Comment on lines
26
to
33
| - name: snyk monitor | ||
| # https://docs.snyk.io/snyk-cli/commands/monitor | ||
| run: snyk monitor --all-projects --severity-threshold=high --exclude=dev,tools | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| - name: snyk test | ||
| # https://docs.snyk.io/snyk-cli/commands/test | ||
| run: snyk test --all-projects --severity-threshold=high --exclude=dev,tools --fail-on=all |
There was a problem hiding this comment.
main change of this PR
joeyorlando
commented
Aug 20, 2024
Comment on lines
-173
to
+181
| "stylelint": "^13.13.1", | ||
| "stylelint": "^14.0.0", | ||
| "stylelint-config-standard": "^22.0.0", | ||
| "throttle-debounce": "^2.1.0", | ||
| "tinycolor2": "^1.6.0", | ||
| "tslib": "2.5.3" | ||
| }, | ||
| "resolutions": { | ||
| "braces": "3.0.3" | ||
| "braces": "3.0.3", | ||
| "micromatch": "4.0.6" |
There was a problem hiding this comment.
patches https://github.com/grafana/oncall-private/issues/2876 (and appeases the failing synk test 🙂)
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
matiasb
approved these changes
Aug 20, 2024
| @@ -23,5 +23,5 @@ runs: | |||
| if: ${{ inputs.install-dependencies == 'true' }} | |||
| shell: bash | |||
| run: | | |||
| pip install uv setuptools | |||
| pip install uv==0.2.37 setuptools==73.0.0 | |||
There was a problem hiding this comment.
Curious, why we need to pin here?
There was a problem hiding this comment.
good catch. I'll revert this, was just testing a few things.
snyk was complaining about a CVE in setuptools=68.0.0. I'm not able to reproduce our environment installing this version though (engine/requirements.txt pins 73.0.0 and this GitHub Action, + our Dockerfile, also install 73.0.0 without the pin).. soo I permanently ignored this warning in snyk for now.
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# Which issue(s) this PR closes Closes #4503 Closes grafana/oncall-private#2876 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR closes
Closes #4503
Closes https://github.com/grafana/oncall-private/issues/2876
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.