Add missing labels permissions, fix tilt ci from ops-devenv, fix expensive e2e tests
#4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasb
approved these changes
Aug 19, 2024
joeyorlando
approved these changes
Aug 19, 2024
| import { test, expect } from '../fixtures'; | ||
| import { clickButton, generateRandomValidLabel, openDropdown } from '../utils/forms'; | ||
| import { openCreateIntegrationModal } from '../utils/integrations'; | ||
| import { goToOnCallPage } from '../utils/navigation'; | ||
|
|
||
| test.skip( | ||
| () => semver.gt(process.env.CURRENT_GRAFANA_VERSION, '10.3.0'), |
There was a problem hiding this comment.
nit what about moving all mentions of process.env.CURRENT_GRAFANA_VERSION to grafana-plugin/e2e-tests/utils/constants.ts?
There was a problem hiding this comment.
Sounds good, will do it now
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
reviewed
Aug 19, 2024
brojd
added a commit
that referenced
this pull request
Sep 18, 2024
…pensive e2e tests (#4842) # What this PR does - add missing labels-related permissions for external service account used by new oncall init process - fix expensive e2e tests in new oncall init process - unify Grafana versions between standard and expensive e2e tests - fix running tilt through ops-devenv in new oncall init process - avoid duplicated standard e2e tests on workflows that run daily and on merges to main ## Which issue(s) this PR closes Related to grafana/oncall-private#2656 <!-- *Note*: If you want the issue to be auto-closed once the PR is merged, change "Related to" to "Closes" in the line above. If you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. --------- Co-authored-by: Joey Orlando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR closes
Related to https://github.com/grafana/oncall-private/issues/2656
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.