add POST /escalation public API endpoint + add public API docs for teams/organization endpoints
#4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
added
the
release:enhancement
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
matiasb
reviewed
Aug 15, 2024
joeyorlando
commented
Aug 15, 2024
|
|
||
| if alert_group_id and (title or message or source_url or grafana_incident_id): | ||
| raise serializers.ValidationError( | ||
| "alert_group_id and (title, message, source_url, grafana_incident_id) are mutually exclusive" | ||
| f"alert_group_id and (title, message, source_url{', grafana_incident_id' if self.ALLOWS_GRAFANA_INCIDENT_ID else ''}) " | ||
| "are mutually exclusive" |
There was a problem hiding this comment.
this is here because the grafana_incident_id is really only a concept that is relevant for the internal API (you cannot specify this attribute from the public API)
Comment on lines
+64
to
+65
| if attrs["users"] and attrs["team"]: | ||
| raise serializers.ValidationError("users and team are mutually exclusive") |
There was a problem hiding this comment.
this is already the case if you perform this workflow from Slack or the web plugin UI, you cannot specify users and a team, we just weren't previously validating the payload for it. Added test cases for this:
joeyorlando
changed the title
joeyorlando
changed the title
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
changed the title
POST /escalation public API endpoint + add public API docs for teams/organization endpoints
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Aug 15, 2024
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
POST /escalationpublic endpoint (equivalent to the internal direct paging API endpoint)Which issue(s) this PR closes
Closes https://github.com/grafana/oncall-private/issues/2859
Closes #2448
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.