fix flaky tests + increase runner size when building docker image #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
joeyorlando
commented
Jun 11, 2024
Comment on lines
-189
to
-191
| (timezone.now() - timezone.timedelta(weeks=50), False), | ||
| (timezone.now() - timezone.timedelta(minutes=4), True), | ||
| (timezone.now() + timezone.timedelta(minutes=4), True), |
There was a problem hiding this comment.
I think the fact that timezone.now was being invoked before the actual test was running was causing some funkiness w/ pytest-xdist
joeyorlando
commented
Jun 11, 2024
Comment on lines
+10
to
+17
| # see this PR regarding the permissions needed for this workflow | ||
| # https://github.com/snyk/actions/pull/79 | ||
| permissions: | ||
| # required for all workflows | ||
| security-events: write | ||
| # only required for workflows in private repositories | ||
| actions: read | ||
| contents: read |
There was a problem hiding this comment.
There was a problem hiding this comment.
scratch that, still not working.. opened a separate issue to fix this
joeyorlando
commented
Jun 11, 2024
| @@ -13,7 +13,7 @@ on: | |||
| jobs: | |||
| build-engine-docker-image-and-publish-to-dockerhub: | |||
| name: Build engine Docker image and publish to Dockerhub | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-latest-16-cores | |||
There was a problem hiding this comment.
trying to see if I can speed up building of our multi-platform Docker image (linux/arm64 + linux/amd64) by just throwing more resources at it.. it seems that installing the Python deps on linux/arm64 takes ~400s
alternative here would be to build the different image variants on different hardware and publish the image manifest separately (something like this, seems much more involved...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR closes
Closes https://github.com/grafana/oncall-private/issues/2733