Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: add support to deploy distributors in both single and multi AZ #9938

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

duricanikolic
Copy link
Contributor

What this PR does

In #9548 we added support to deploy distributors in multi availability zones (AZ). One of the features of that PR was that deploying distributors in multi-AZ implicitly implies that they cannot be deployed in a single-AZ, and vice versa.

This PR removes that constraint, and allow distributors to be deployed in both modes. This would be needed for migration from single to multi-AZ.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@duricanikolic duricanikolic self-assigned this Nov 18, 2024
@duricanikolic duricanikolic requested a review from a team as a code owner November 18, 2024 13:00
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

operations/mimir/multi-zone-distributor.libsonnet Outdated Show resolved Hide resolved
@duricanikolic duricanikolic merged commit da190b5 into main Nov 19, 2024
29 checks passed
@duricanikolic duricanikolic deleted the yuri/distributor-single-multi-az branch November 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants