fix marshaling error on invalid label value #9828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
andyasp
pushed a commit
that referenced
this pull request
Nov 4, 2024
* fix marshaling error on invalid label value Signed-off-by: Mauro Stettler <[email protected]> * only return label and metric Signed-off-by: Mauro Stettler <[email protected]> * changelog Signed-off-by: Mauro Stettler <[email protected]> --------- Signed-off-by: Mauro Stettler <[email protected]> (cherry picked from commit c7ce088) Co-authored-by: Mauro Stettler <[email protected]>
aknuds1
pushed a commit
that referenced
this pull request
Nov 5, 2024
* fix marshaling error on invalid label value Signed-off-by: Mauro Stettler <[email protected]> * only return label and metric Signed-off-by: Mauro Stettler <[email protected]> * changelog Signed-off-by: Mauro Stettler <[email protected]> --------- Signed-off-by: Mauro Stettler <[email protected]>
4 tasks
aknuds1
added a commit
that referenced
this pull request
Nov 5, 2024
* fix marshaling error on invalid label value * only return label and metric * changelog --------- Signed-off-by: Mauro Stettler <[email protected]> Co-authored-by: Mauro Stettler <[email protected]>
aknuds1
pushed a commit
that referenced
this pull request
Nov 5, 2024
* fix marshaling error on invalid label value Signed-off-by: Mauro Stettler <[email protected]> * only return label and metric Signed-off-by: Mauro Stettler <[email protected]> * changelog Signed-off-by: Mauro Stettler <[email protected]> --------- Signed-off-by: Mauro Stettler <[email protected]>
4 tasks
aknuds1
pushed a commit
that referenced
this pull request
Nov 5, 2024
* fix marshaling error on invalid label value Signed-off-by: Mauro Stettler <[email protected]> * only return label and metric Signed-off-by: Mauro Stettler <[email protected]> * changelog Signed-off-by: Mauro Stettler <[email protected]> --------- Signed-off-by: Mauro Stettler <[email protected]>
4 tasks
aknuds1
added a commit
that referenced
this pull request
Nov 5, 2024
* fix marshaling error on invalid label value * only return label and metric * changelog --------- Signed-off-by: Mauro Stettler <[email protected]> Co-authored-by: Mauro Stettler <[email protected]>
aknuds1
added a commit
that referenced
this pull request
Nov 5, 2024
* fix marshaling error on invalid label value * only return label and metric * changelog --------- Signed-off-by: Mauro Stettler <[email protected]> Co-authored-by: Mauro Stettler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that when a label value fails validation due to invalid UTF-8 characters we don't return these invalid characters in the error, because including them can break the rendering of the error that should be returned.