helm: add enabled field for admin-api,compactor,distributor,gateway,ingester,querier,query-frontend,store-gateway
#9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2024
Comment on lines
-21
to
-22
| instrumentation: | ||
| enabled: false |
There was a problem hiding this comment.
now this is automatically set up
| @@ -10,7 +10,7 @@ compactor: | |||
| ingester: | |||
| schedulerName: my-scheduler | |||
|
|
|||
| store-gateway: | |||
| store_gateway: | |||
There was a problem hiding this comment.
unrelated to the PR, but it's wrong test config which i noticed
Comment on lines
292
to
295
| {{- if .Values.distributor.enabled }} | ||
| distributor: | ||
| url: dns:///{{ template "mimir.fullname" . }}-distributor-headless.{{ .Release.Namespace }}.svc.{{ .Values.global.clusterDomain }}:{{ include "mimir.serverGrpcListenPort" . }} | ||
| {{- end }} |
There was a problem hiding this comment.
the gateway would try to resolve the dns:/// address before starting. Since it's not there, we shouldn't set it up.
charleskorn
reviewed
Oct 25, 2024
technically the FF doesn't use either, but it keeps the config consistent with other components. I guess that's not a good enough reason. I'll remove them along with the update: they're disabled in eda445e most of the disableOtherComponents work is done in 6a4f68e |
charleskorn
approved these changes
Nov 6, 2024
...ons/helm/charts/mimir-distributed/ci/offline/test-enterprise-federation-frontend-values.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
force-pushed
the
dimitar/helm/add-enabled-falgs-to-components
branch
from
eda445e to
13cd3b6
Compare
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
force-pushed
the
dimitar/helm/add-enabled-falgs-to-components
branch
from
299a2b1 to
383dca1
Compare
This reverts commit 383dca1.
dimitarvdimitrov
deleted the
dimitar/helm/add-enabled-falgs-to-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This adds
enabledflag for a few components which are normally required for a Mimir/GEM deployment. We need this so that deploying the federation-frontend doesn't end up deploying a ton of unrelated and unnecessary resources.federation_frontend.disableOtherComponentsto have the same effect as settingenabled: falseon all components.I've also disabled them in the rendered federation-frontend values. Now all the files when rendering the federation-frontend are these:
Which issue(s) this PR fixes or relates to
Related to #9672
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.