Ingester: add tracing to shipper.Sync #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
ingester-block-traces
branch
from
1d797a6 to
28d5c61
Compare
I see a lot of unattached spans from `storage.Object.Attrs` and `storage.Object.Writer`; creating one large span for `shipper.Sync` should join them all up into something more meaningful.
bboreham
force-pushed
the
ingester-block-traces
branch
from
28d5c61 to
45fd26d
Compare
dimitarvdimitrov
approved these changes
Oct 18, 2024
jhalterman
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I see a lot of unattached spans from
storage.Object.Attrsandstorage.Object.Writer; creating one large span forshipper.Syncshould join them all up into something more meaningful.Using a spanlogger so existing log messages also appear in the trace.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].