-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor minio fullname #9565
Honor minio fullname #9565
Conversation
Solution from here: https://stackoverflow.com/a/69515809 |
The fix looks good to me. But I think there is one place in the changeset, that also needs fixing (refer to the in place comment). Also, could you add a |
operations/helm/charts/mimir-distributed/templates/minio/create-bucket-job.yaml
Show resolved
Hide resolved
ac34257
to
1a0dc94
Compare
anyway, what do you think: in values.yaml mimir config endpoint sould use |
That's a great point, thank you. Fixing it should be a noop for the chart and its tests so if you could fix the values here, that'd be nice. |
Changed the port to minio.service values |
Signed-off-by: Vladimir Varankin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Looks good, thank you
What this PR does
the subchart full name override is not honored is referenced template files. (eg minio service name or configmap name)
Which issue(s) this PR fixes or relates to
Fixes #9564.