MQE: include more information in query stats log lines #9505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/mqe-query-stats-log-lines
branch
from
8305f4a to
fcb3def
Compare
# Conflicts: # CHANGELOG.md
charleskorn
force-pushed
the
charleskorn/mqe-query-stats-log-lines
branch
from
fcb3def to
e4e31ae
Compare
jhesketh
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds more information to the "query stats" log lines emitted by MQE.
Specifically, it adds the expression, query type, time range and step.
This makes it easier to identify which query stats log line belongs to which query when the request trace is not sampled, as otherwise there is no identifying information beyond the time.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.