-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: release notes for 5.5.0 #9489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c44b804
to
67024fa
Compare
lamida
reviewed
Oct 2, 2024
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
c724561
to
1078e3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd wait for an approval from @tacole02 too
docs/sources/helm-charts/mimir-distributed/release-notes/v5.5.md
Outdated
Show resolved
Hide resolved
dimitarvdimitrov
approved these changes
Oct 3, 2024
tacole02
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a few minor suggestions and one question for clarification.
docs/sources/helm-charts/mimir-distributed/release-notes/v5.5.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/mimir-distributed/release-notes/v5.5.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/mimir-distributed/release-notes/v5.5.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/mimir-distributed/release-notes/v5.5.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/mimir-distributed/release-notes/v5.5.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Taylor C <[email protected]>
grafanabot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* helm: release notes for 5.5.0 Signed-off-by: Vladimir Varankin <[email protected]> * reformat text Signed-off-by: Vladimir Varankin <[email protected]> * Apply suggestions from code review Co-authored-by: Taylor C <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]> Co-authored-by: Taylor C <[email protected]> (cherry picked from commit 29160c8)
narqo
added a commit
that referenced
this pull request
Oct 4, 2024
* helm: release notes for 5.5.0 Signed-off-by: Vladimir Varankin <[email protected]> * reformat text Signed-off-by: Vladimir Varankin <[email protected]> * Apply suggestions from code review Co-authored-by: Taylor C <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]> Co-authored-by: Taylor C <[email protected]> (cherry picked from commit 29160c8) Co-authored-by: Vladimir Varankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I wrote the notes based on 5.5.0-rc.0 changelog #9487. There aren't much of changes in the release and I tried to focus on those, that potentially affect the users.
Which issue(s) this PR fixes or relates to
Relates to #9382
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.