Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimir query engine: Introduce FunctionOverInstantVector type #9136

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Mimir query engine: Introduce FunctionOverInstantVector type #9136

merged 2 commits into from
Aug 30, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Aug 30, 2024 •
edited
Loading

What this PR does

This PR is a refactoring: it introduces a FunctionOverInstantVector type to MQE, similar to the FunctionOverRangeVector type introduced in #8860.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review August 30, 2024 00:35
@charleskorn charleskorn requested a review from a team as a code owner August 30, 2024 00:35
jhesketh
jhesketh approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@charleskorn charleskorn merged commit 0a0255d into main Aug 30, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/instant-vector-function-refactor branch August 30, 2024 01:43
@charleskorn charleskorn mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @jhesketh