Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query pruning middleware #9086

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Add query pruning middleware #9086

merged 13 commits into from
Sep 12, 2024

Conversation

zenador
Copy link
Contributor

@zenador zenador commented Aug 23, 2024

What this PR does

(Hackathon project) Query pruning optimises PromQL queries by rewriting them to avoid evaluating expressions that can't produce a result, which is particularly useful in dashboards with toggles between native and classic histograms.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@zenador zenador marked this pull request as ready for review August 23, 2024 20:57
@zenador zenador requested review from tacole02 and a team as code owners August 23, 2024 20:57
@krajorama krajorama self-requested a review August 23, 2024 22:01
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, I only have a couple of minor comments

Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

@krajorama
Copy link
Contributor

Solves #9065

@zenador zenador force-pushed the zenador/query-pruning branch from b1c8758 to 7c784d8 Compare September 9, 2024 18:32
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zenador zenador enabled auto-merge (squash) September 12, 2024 07:12
@zenador zenador merged commit 1e98df0 into main Sep 12, 2024
29 checks passed
@zenador zenador deleted the zenador/query-pruning branch September 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants