-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add support for docker healthcheck
to grafana/mimir
image
#9035
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide more information about why this is necessary? (ie. why do you want to use Docker's healthcheck feature?)
We intentionally chose to use distroless images to minimise the number of dependencies in the image, particularly tools like shells and HTTP clients that tend to have vulnerabilities or could be used to pivot from another vulnerability.
Orchestration tools / load balancers can use the healthcheck feature to determine when a container is ready to accept traffic.
It is the same It is possible to use the internal commands to check the health of the service, as described in the alternatives. |
Which orchestration tool or load balancer are you using @DeadNews? Most support a simple HTTP healthcheck, and this is what I'd encourage you to use. Mimir already has a |
You can read from here and below. It's the exact same questions. I referenced it in the issue. To answer the question: |
@@ -69,6 +69,7 @@ | |||
* [ENHANCEMENT] Make `-query-frontend.additional-query-queue-dimensions-enabled` and `-query-scheduler.additional-query-queue-dimensions-enabled` non-operational flags in preparation for removal. #8984 | |||
* [ENHANCEMENT] Add a new ingester endpoint to prepare instances to downscale. #8956 | |||
* [ENHANCEMENT] Query-scheduler: Add `query-scheduler.prioritize-query-components` which, when enabled, will primarily prioritize dequeuing fairly across queue components, and secondarily prioritize dequeuing fairly across tenants. When disabled, tenant fairness is primarily prioritized. `query-scheduler.use-multi-algorithm-query-queue` must be enabled in order to use this flag. #9016 | |||
* [ENHANCEMENT] Build: `grafana/mimir` docker image is now support docker `healthcheck`. #9034 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [ENHANCEMENT] Build: `grafana/mimir` docker image is now support docker `healthcheck`. #9034 | |
* [ENHANCEMENT] Build: `grafana/mimir` docker image supports docker `healthcheck`. #9034 |
Sorry @DeadNews, we're not interested in adding any dependencies to the distroless image. If this is required for your use case, it should easy enough to build a custom Mimir image. |
What this PR does
Add support for docker
healthcheck
tografana/mimir
image.Like loki does:
debug
tag is used to havebusybox
available in the image.Which issue(s) this PR fixes or relates to
Fixes #9034
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.