Mimir query engine: pass enabled feature toggles to engine #8986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
approved these changes
Aug 13, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-8986-to-r303 origin/r303
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1dfcdd5cfd3e01d43992c2f14071c3a7a44a3a77
# Push it to GitHub
git push --set-upstream origin backport-8986-to-r303
git switch main
# Remove the local backport branch
git branch -D backport-8986-to-r303Then, create a pull request where the |
charleskorn
added a commit
that referenced
this pull request
Aug 13, 2024
* Mimir query engine: pass enabled feature toggles to engine * Add changelog entry (cherry picked from commit 1dfcdd5)
charleskorn
added a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue in #8872.
The enabled feature toggles were not passed to MQE, so it would assume that all feature toggles are disabled.
Which issue(s) this PR fixes or relates to
#8872
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.