Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir query engine: add support for count_over_time, present_over_time and last_over_time #8925

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Aug 7, 2024

What this PR does

This PR adds support in MQE for the following PromQL functions:

  • count_over_time
  • present_over_time
  • last_over_time

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn force-pushed the charleskorn/over-time-functions branch from e0d6d2a to ef10b49 Compare August 7, 2024 06:32
@charleskorn charleskorn force-pushed the charleskorn/over-time-functions branch from d2b9b99 to 0425dff Compare August 7, 2024 07:00
@charleskorn charleskorn changed the title Mimir query engine: add support for some ..._over_time functions Mimir query engine: add support for count_over_time, present_over_time and last_over_time Aug 7, 2024
@charleskorn charleskorn marked this pull request as ready for review August 7, 2024 07:21
@charleskorn charleskorn requested review from tacole02 and a team as code owners August 7, 2024 07:21
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor thing.

Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

# Conflicts:
#	CHANGELOG.md
#	cmd/mimir/help-all.txt.tmpl
#	docs/sources/mimir/configure/configuration-parameters/index.md
#	pkg/streamingpromql/config.go
@charleskorn charleskorn enabled auto-merge (squash) August 8, 2024 00:54
@charleskorn charleskorn merged commit b5098c5 into main Aug 8, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/over-time-functions branch August 8, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants